feat: generate backend environment template - #10
Open
teleginzhenya wants to merge 1 commit into
Open
Conversation
Reviewer's GuideThis PR updates the scaffolding generators to create a backend-only File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
generateNodekit, consider guarding the.env-templatewrite withmodel.hasBackendso that it’s only created for backend-enabled projects, which would better align with the README comments and the new test that expects no.env-templatewhen there is no backend.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `generateNodekit`, consider guarding the `.env-template` write with `model.hasBackend` so that it’s only created for backend-enabled projects, which would better align with the README comments and the new test that expects no `.env-template` when there is no backend.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.env-templatewithAPP_DEV_MODE=truefor scaffolded backend projects.envand the resulting human-readable NodeKit logsTesting
npm test(86 tests)npx tsc --noEmitnpm run lint -- --fixnpm run lint:prettiernpm run knipnpm run buildI hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Summary by Sourcery
Generate a backend environment template and document its usage in scaffolded projects.
New Features:
.env-templatefile in backend NodeKit projects to enable readable development logs.Enhancements:
.env-templatein the project structure.Tests:
.env-templatecreation/omission for backend and non-backend projects.